refactor: migrate configuration system from JSON Schema to QuickType #1140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1140 +/- ##
==========================================
+ Coverage 83.29% 84.79% +1.49%
==========================================
Files 59 60 +1
Lines 2449 2539 +90
Branches 280 313 +33
==========================================
+ Hits 2040 2153 +113
+ Misses 365 330 -35
- Partials 44 56 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace JSON-Schema for config validation and default injection
Add typed
configexport,loadConfig(),validate()andsetConfigFile()Update
index.tsto use the new loader and pass the validated config.Note: Restored from deleted fork
This PR recreates the original PR #998, which was automatically closed due to accidental fork deletion.
** For discussions and reviews:** See the original PR #998
All commits are identical to the original with preserved git history.